Skip to content

cp: remove feat_acl & exacl - #13626

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:cp-attr
Aug 4, 2026
Merged

cp: remove feat_acl & exacl#13626
cakebaker merged 1 commit into
uutils:mainfrom
oech3:cp-attr

Conversation

@oech3

@oech3 oech3 commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #13056 . xattr is already dep of rustix. We already do copy_acls.

@sylvestre

sylvestre commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

a bunch of jobs are failing

@oech3
oech3 force-pushed the cp-attr branch 4 times, most recently from 8d0cb34 to 524c527 Compare July 29, 2026 06:48
@oech3

oech3 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

yes. I was missing cfg

@github-actions

github-actions Bot commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@oech3
oech3 force-pushed the cp-attr branch 2 times, most recently from 8b27788 to 890f350 Compare July 29, 2026 08:45
@oech3

oech3 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

I gated code with same targets supported by exacl.

@oech3

oech3 commented Aug 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

We already do copy_acls. Can we just remove exacl?

@oech3
oech3 force-pushed the cp-attr branch 2 times, most recently from a2675b8 to 42e6893 Compare August 2, 2026 06:48
@oech3 oech3 changed the title cp: remove feat_acl & replace exacl by xattr cp: remove feat_acl & exacl Aug 2, 2026
@oech3
oech3 force-pushed the cp-attr branch 2 times, most recently from de52e04 to d3d6062 Compare August 3, 2026 21:09
@codspeed-hq

codspeed-hq Bot commented Aug 3, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 3.06%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 346 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation du_max_depth_balanced_tree[(6, 4, 10)] 60.7 ms 62.6 ms -3.06%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing oech3:cp-attr (d3d6062) with main (fe9420b)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (89bdbb8) during the generation of this report, so fe9420b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@cakebaker
cakebaker merged commit 8d68f13 into uutils:main Aug 4, 2026
167 of 168 checks passed
@cakebaker

cakebaker commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@oech3
oech3 deleted the cp-attr branch August 4, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cp: replace exacl by uutils/acl & remove feat_acl

3 participants

@oech3 @sylvestre @cakebaker